Code review comment for lp:~laurynas-biveinis/percona-pam-for-mysql/import-dialog

Sergei -

2011/12/9 Sergei <email address hidden>:
>> Well, I can just use the original get_tty_password(), cannot I?
>
> >From vanilla MySQL? Yes, but it does unnecessary my_strdup().
> All I've done was to remove the my_strdup() and use a preallocated
> buffer. Compare our libmysql/get_password.c and the vanilla one.

Yes, I have compared all the password getters I was able to find. To
use the non-buf version I only have to link with libmysqlclient -
which is one of the installed libs - and I don't have to import any
sources or anything. It has the extra my_strdup(), but it seems a
pretty good trade-off to me.

--
Laurynas