Code review comment for lp:~laurynas-biveinis/percona-pam-for-mysql/import-dialog

Hi, Laurynas!

On Dec 08, Laurynas Biveinis wrote:
> Sergei -
>
> Thanks for your comments! I have reviewed MariaDB's dialog.c, compared
> it against the Oracle version and I think there is not much difference
> in either picking Oracle version and then cherry-picking your changes
> or taking yours and cherry-picking Oracle API (get_tty_password vs
> get_tty_password_buf) and plugin declaration stuff. It seems to me
> that the former option is easier, thus my original MP still stands.

get_tty_password_buf() is something I've added just a few days ago. If
you copy dialog.c into your project, then, I suppose, you need to copy
get_tty_password_buf() too. You cannot expect the client to have it.

> Also, what about my original question? Would you like to have dialog
> compilation disabled if building with MariaDB and if yes, what's the
> official way to do that?

Don't worry about it. When we'll decide to include percona pam plugin,
I'l handle this (and plug.in file, and the rest of the integration).

Regards,
Sergei