Code review comment for lp:~laurynas-biveinis/percona-pam-for-mysql/import-dialog

Hi, Laurynas!

On Dec 06, Laurynas Biveinis wrote:
> Laurynas Biveinis has proposed merging lp:~laurynas-biveinis/percona-pam-for-mysql/import-dialog into lp:percona-pam-for-mysql.
>
> Requested reviews:
> pam-for-mysql-developers (pam-for-mysql-developers)
>
> For more details, see:
> https://code.launchpad.net/~laurynas-biveinis/percona-pam-for-mysql/import-dialog/+merge/84616
>
> Copy plugin/auth_example/dialog.c from lp:mysql-server/5.5 revno 3638.
>
> This is a preparation for dialog changes not to echo passwords with
> the default ask function. No source proper changes in this MP to have
> better change history.
>
> MariaDB folks, if I understand correctly, this is unnecessary for you.
> Please let me know if there is a configure-time check I could use to
> disable building dialog under MariaDB. Thanks!

Copy dialog.c from the latest mariadb-5.2 instead. In has numerous bug
fixes:

1. Works on windows. That is, it loads and callback works.
2. Better behavior, regarding when to send a password (from mysql -pXXX)
3. Does not echo the password input by default. No, it's not just using
   getpass - but a more complex and portable logic, see get_tty_password
   from mysql or mariadb client library.

you may be also interested to see the dialog and pam tests in out test suite.

Regards,
Sergei