Code review comment for lp:~launchpad/launchpad/recife

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Okay, that diff may have been a little much for display here. The relevant parts are:

--- database/schema/comments.sql 2010-10-26 16:22:57 +0000
+++ database/schema/comments.sql 2010-11-22 07:04:28 +0000
@@ -2,7 +2,7 @@
   Add Comments to Launchpad database. Please keep these alphabetical by
   table.

- Copyright 2009 Canonical Ltd. This software is licensed under the
+ Copyright 2009-2010 Canonical Ltd. This software is licensed under the
      GNU Affero General Public License version 3 (see the file LICENSE).
 */

@@ -971,10 +971,10 @@
 validated this translation. Being 0 the value that says this row has not been
 validated yet, 1 the value that says it is correct and 2 the value noting that
 there was an unknown error with the validation.';
-COMMENT ON COLUMN TranslationMessage.is_current IS 'Whether this translation
-is being used in Launchpad.';
-COMMENT ON COLUMN TranslationMessage.is_imported IS 'Whether this translation
-is being used in latest imported file.';
+COMMENT ON COLUMN TranslationMessage.is_current_ubuntu IS 'Whether this translation
+is being used in Ubuntu.';
+COMMENT ON COLUMN TranslationMessage.is_current_upstream IS 'Whether this translation
+is being used upstream.';
 COMMENT ON COLUMN TranslationMessage.was_obsolete_in_last_import IS 'Whether
 this translation was obsolete in last imported file.';

@@ -2036,7 +2036,7 @@
 COMMENT ON COLUMN TranslationImportQueueEntry.distroseries IS 'The distribution release related to this import.';
 COMMENT ON COLUMN TranslationImportQueueEntry.sourcepackagename IS 'The source package name related to this import.';
 COMMENT ON COLUMN TranslationImportQueueEntry.productseries IS 'The product series related to this import.';
-COMMENT ON COLUMN TranslationImportQueueEntry.is_published IS 'Notes whether is a published upload.';
+COMMENT ON COLUMN TranslationImportQueueEntry.by_maintainer IS 'Notes whether this upload was done by the maintiner of the package or project.';
 COMMENT ON COLUMN TranslationImportQueueEntry.pofile IS 'Link to the POFile where this import will end.';
 COMMENT ON COLUMN TranslationImportQueueEntry.potemplate IS 'Link to the POTemplate where this import will end.';
 COMMENT ON COLUMN TranslationImportQueueEntry.date_status_changed IS 'The date when the status of this entry was changed.';

--- database/schema/patch-2208-99-0.sql 1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-99-0.sql 2010-11-22 07:04:28 +0000
@@ -0,0 +1,27 @@
+-- Copyright 2010 Canonical Ltd. This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE TranslationMessage
+RENAME is_current TO is_current_ubuntu;
+ALTER TABLE TranslationMessage
+RENAME is_imported TO is_current_upstream;
+
+ALTER INDEX tm__potmsgset__language__shared__current__key
+RENAME TO tm__potmsgset__language__shared__ubuntu__key;
+
+ALTER INDEX tm__potmsgset__language__shared__imported__key
+RENAME TO tm__potmsgset__language__shared__upstream__key;
+
+ALTER INDEX tm__potmsgset__potemplate__language__diverged__current__idx
+RENAME TO tm__potmsgset__template__language__diverged__ubuntu__key;
+
+ALTER INDEX tm__potmsgset__potemplate__language__diverged__imported__idx
+RENAME TO tm__potmsgset__template__language__diverged__upstream__key;
+
+ALTER INDEX translationmessage__language__submitter__idx
+RENAME TO tm__language__submitter__idx;
+
+-- XXX: Update patch number!
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 99, 0)

--- database/schema/patch-2208-99-1.sql 1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-99-1.sql 2010-11-22 07:04:28 +0000
@@ -0,0 +1,9 @@
+-- Copyright 2010 Canonical Ltd. This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+
+SET client_min_messages=ERROR;
+
+ALTER TABLE TranslationImportQueueEntry
+ RENAME COLUMN is_published TO by_maintainer;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 99, 1);

« Back to merge proposal