Code review comment for lp:~lasall/ppa-purge/dryrun

On 19/03/13 23:09, Tormod Volden wrote:
> Yes, but that won't help much if apt-get update hasn't been run with the modified sources list, will it?
Hm, didn't thought at this.

> Maybe more useful than your current patch, which only helps to verify the PPA name, would be to actually disable the PPA in the sources list (requiring superuser) and run the apt-get install with --simulate, then restore the sources list?
I would rather suggest to use an other switch for that. Because this
operation is much more non-trivial than a "dryrun". If you agree to make
this a new option (and name the switch), I will add the functionality:

 0. Update.
 1. Disable sources but make a backup (where a change is needed),
something like foobar.list.ppa-purge.save (and make sure this file not
already exists).
 2. Update.
 3. --simulate
 4. Restore backup.
 5. Update.

At that point it would be useful to display a message as long the update
is running and remove it with control sequences, e.g.:
  echo -n "Update sources..."; echo -n "\rUpdate finished. \n"

My first motivation for the "dryrun"-switch was to debug the file list
name and see if it's possible to disable other sources than a Launchpad
PPA. (At the moment this is not fully possible - everything works except
disabling the sources entry.)