Code review comment for lp:~larsu/ubuntu-ui-toolkit/custom-icon-lookup
Revision history for this message
| Lars Karlitski (larsu) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Thanks for looking at this. I've removed the sizing workarounds in the Icon component (so that we can move StatusIcon users to Icon).
> The only problem I see with this is that because "size" does not say whether it's width or height, we'll be using non-optimal images when they are not square.
Right. Let's see if we run into a lot of trouble because of this. If we do, it might be time to amend the fdo spec.