Code review comment for lp:~larsu/notify-osd/update-sync

Revision history for this message
Mirco Müller (macslow) wrote :

While the patch is generally ok code-wise, this still is a shift from notify-osd's design-spec. Since I've not seen any feedback form Design on the bug in the comments regarding this change, I suggest getting their input on the issue.

Meanwhile I'll provide a solution in the bug's comments, which stays within notify-osd's initial design and addresses the requirement within this scope.

review: Needs Information

« Back to merge proposal