Merge lp:~larsu/nautilus/remove-titlebar-css-patch into lp:~ubuntu-desktop/nautilus/ubuntu

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 433
Merged at revision: 436
Proposed branch: lp:~larsu/nautilus/remove-titlebar-css-patch
Merge into: lp:~ubuntu-desktop/nautilus/ubuntu
Diff against target: 124 lines (+7/-94)
3 files modified
debian/changelog (+7/-0)
debian/patches/series (+0/-1)
debian/patches/ubuntu_titlebar_css.patch (+0/-93)
To merge this branch: bzr merge lp:~larsu/nautilus/remove-titlebar-css-patch
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+226317@code.launchpad.net

Commit message

Remove ubuntu_titlebar_css.patch

The relevant rules have been added to the themes.

Description of the change

Remove ubuntu_titlebar_css.patch

The relevant rules have been added to the themes.

Soft-depends on lp:~larsu/ubuntu-themes/three-twelve (it will work without, but nautilus' toolbar is styled wrong).

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks! The themes changes are in a landing, let's wait for that to be in the archive before uploading nautilus

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-05-13 11:48:27 +0000
3+++ debian/changelog 2014-07-10 15:12:03 +0000
4@@ -1,3 +1,10 @@
5+nautilus (1:3.10.1-0ubuntu12) UNRELEASED; urgency=medium
6+
7+ * debian/patches/ubuntu_titlebar_css.patch:
8+ - Remove; the css fixes have been added to the theme
9+
10+ -- Lars Uebernickel <lars.uebernickel@ubuntu.com> Thu, 10 Jul 2014 17:08:31 +0200
11+
12 nautilus (1:3.10.1-0ubuntu11) utopic; urgency=medium
13
14 * debian/patches/git_revert_symlink_logic_change.patch:
15
16=== modified file 'debian/patches/series'
17--- debian/patches/series 2014-05-13 11:48:11 +0000
18+++ debian/patches/series 2014-07-10 15:12:03 +0000
19@@ -23,7 +23,6 @@
20 ubuntu_show_titlebar.patch
21 restore-traditional-menu-bar.patch
22 16_unity_new_documents.patch
23-ubuntu_titlebar_css.patch
24 ubuntu_backspace_behaviour.patch
25 git_valid_location_widget.patch
26 ubuntu_infobars_color.patch
27
28=== removed file 'debian/patches/ubuntu_titlebar_css.patch'
29--- debian/patches/ubuntu_titlebar_css.patch 2014-01-25 01:49:27 +0000
30+++ debian/patches/ubuntu_titlebar_css.patch 1970-01-01 00:00:00 +0000
31@@ -1,93 +0,0 @@
32-From: Tim Lunn <tim@feathertop.org>
33-Date: Fri, 24 Jan 2014 08:24:31 +1100
34-Subject: [PATCH] Override some css theming for nautilus topbar
35-Description: This patch overrides a few css properties for the nautilus header bar,
36-done from here rather than in the themes since nautilus uses a non-standard header
37-bar implementation.
38-
39----
40- src/nautilus-toolbar.c | 40 +++++++++++++++++++++++++++++++++++++++-
41- 1 file changed, 39 insertions(+), 1 deletion(-)
42-
43---- a/src/nautilus-toolbar.c
44-+++ b/src/nautilus-toolbar.c
45-@@ -81,6 +81,43 @@
46- !show_location_entry);
47- }
48-
49-+static void
50-+toolbar_override_css (GtkWidget *widget,
51-+ const gchar *name,
52-+ const gchar *css_string)
53-+{
54-+ GtkCssProvider *css;
55-+ GtkSettings* settings;
56-+ GError *error = NULL;
57-+ gchar *theme_name;
58-+
59-+ settings = gtk_settings_get_default();
60-+ g_object_get(settings, "gtk-theme-name", &theme_name, NULL);
61-+
62-+ if (g_strcmp0(theme_name, "Ambiance") == 0 || g_strcmp0(theme_name, "Radiance") == 0)
63-+ {
64-+ gtk_widget_set_name (widget, name);
65-+ css = gtk_css_provider_new ();
66-+ if (gtk_css_provider_load_from_data (css,
67-+ css_string,
68-+ -1, &error))
69-+ {
70-+ GtkStyleContext *context = gtk_widget_get_style_context (widget);
71-+ gtk_style_context_add_provider (context, (GtkStyleProvider *) css,
72-+ GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
73-+ }
74-+ else
75-+ {
76-+ g_warning ("Error processing CSS theme override: %s", error->message);
77-+ g_clear_error (&error);
78-+ }
79-+ g_object_unref (css);
80-+ }
81-+ g_free (theme_name);
82-+}
83-+
84-+
85-+
86- static GtkWidget *
87- toolbar_create_toolbutton (NautilusToolbar *self,
88- gboolean create_menu,
89-@@ -91,6 +128,7 @@
90- GtkWidget *button, *image;
91- GtkActionGroup *action_group;
92- GtkAction *action;
93-+ const gchar *css_string;
94-
95- action_group = nautilus_window_get_main_action_group (self->priv->window);
96-
97-@@ -117,6 +155,9 @@
98- gtk_widget_set_tooltip_text (button, gtk_action_get_tooltip (action));
99- }
100-
101-+ css_string = "GtkButton#toolbar-button {padding: 9px;}";
102-+ toolbar_override_css (button, "toolbar-button", css_string);
103-+
104- return button;
105- }
106-
107-@@ -399,6 +440,7 @@
108- GtkWidget *separator;
109- GtkUIManager *ui_manager;
110- gboolean rtl;
111-+ const gchar *css_string;
112-
113- G_OBJECT_CLASS (nautilus_toolbar_parent_class)->constructed (obj);
114-
115-@@ -408,6 +450,9 @@
116- self->priv->toolbar = toolbar = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
117- gtk_container_add (GTK_CONTAINER (self), toolbar);
118-
119-+ css_string = ".header-bar { border-radius: 0; padding: 1px;}";
120-+ toolbar_override_css (GTK_WIDGET (self), "toolbar", css_string);
121-+
122- rtl = gtk_widget_get_default_direction () == GTK_TEXT_DIR_RTL;
123-
124- ui_manager = nautilus_window_get_ui_manager (self->priv->window);

Subscribers

People subscribed via source and target branches

to all changes: