Merge lp:~larsu/libdbusmenu/lp1053670 into lp:libdbusmenu/12.10
Proposed by
Lars Karlitski
Status: | Merged |
---|---|
Approved by: | Charles Kerr |
Approved revision: | 427 |
Merge reported by: | Lars Karlitski |
Merged at revision: | not available |
Proposed branch: | lp:~larsu/libdbusmenu/lp1053670 |
Merge into: | lp:libdbusmenu/12.10 |
Diff against target: |
52 lines (+16/-6) 1 file modified
libdbusmenu-gtk/parser.c (+16/-6) |
To merge this branch: | bzr merge lp:~larsu/libdbusmenu/lp1053670 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr (community) | Approve | ||
Review via email: mp+126047@code.launchpad.net |
Description of the change
This tries to fix bug #1053670. I'm not sure it actually fixes it, because I can't reproduce.
The problem seems to be that settings_notify_cb is called with an invalid DbusmenuMenuitem instance as user_data. This should only happen when the signal is not disconnected properly. I think it isn't, because `widget` might already be NULL in parser_data_free (the menu item has a g_object_
This patch gives ParserData a ref to the GtkSettings object to whose "gtk-menu-images" signal it connects and disconnects the signal from that instance.
To post a comment you must log in.
I can't reproduce this crash either, but the patch looks reasonable and I agree with its logic.