lp:~larsu/indicator-sound/lp710824

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:indicator-sound/14.04 at revision 401

Charles Kerr (community): Approve on 2013-10-30

PS Jenkins bot (community): Approve (continuous-integration) on 2013-10-30

Diff: 147 lines (+31/-12)

4 files modified

src/CMakeLists.txt (+2/-0)
src/media-player-list.vala (+1/-1)
src/media-player.vala (+24/-9)
src/service.vala (+4/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #710824: Sound applications without main window should behave different

Medium

Fix Released

Link a bug report

Related blueprints

403. By Lars Karlitski on 2013-10-30

Make player menu item insensitive when player can't be raised

402. By Lars Karlitski on 2013-10-30

Call Raise() when activating a player menu item

401. By Lars Karlitski on 2013-10-30

Rename MediaPlayer.launch() ot activate()

400. By PS Jenkins bot on 2013-10-29

Releasing 12.10.2+14.04.20131029.1-0ubuntu1 (revision 399 from lp:indicator-sound).

Approved by PS Jenkins bot.

399. By Lars Karlitski on 2013-10-29

Depend on vala 0.20 and use its GIcon.serialize().

Approved by PS Jenkins bot, Charles Kerr.

398. By Charles Kerr on 2013-10-28

Test that MediaPlayer's icon property isn't NULL before we serialize it. Fixes: https://bugs.launchpad.net/bugs/1229612.

Approved by PS Jenkins bot, Lars Uebernickel.

397. By Ted Gould on 2013-10-28

Adding a phone_greeter profile.

Approved by Charles Kerr, PS Jenkins bot.

396. By Lars Karlitski on 2013-10-28

VolumeControl: don't pass vala closures into libpulse

Libpulse's vala bindings don't specify that callbacks passed into some of its functions (e.g., get_server_info) can be called after the function returns. Vala thus frees closure data after these functions return.

This can't easily be fixed in the bindings, because libpulse doesn't provide variants of these functions with destroy_notifies.

This patch works around this problem by only passing non-closure functions into libpulse. Fixes: https://bugs.launchpad.net/bugs/1244386.

Approved by Charles Kerr, PS Jenkins bot.

395. By Charles Kerr on 2013-10-25

In Service's volume_changed() function, explicitly instantiate the GVariant to avoid leaking it. See the description in bug #1244468 for before & after C code and more information. Fixes: https://bugs.launchpad.net/bugs/1244468.

Approved by Lars Uebernickel, PS Jenkins bot.

394. By Sebastien Bacher on 2013-10-24

Don't special case Unity sessions, that's not needed since
gnome-control-center is doing the right thing, the session name used
was also wrong and couldn't work (lp: #1239545). Fixes: https://bugs.launchpad.net/bugs/1239545.

Approved by Charles Kerr, PS Jenkins bot.