Ubuntu
indicator-sound package

If intending to use soundnua in an ubuntu session then specify "ubuntu" as session

Bug #1239545 reported by Doug McMahon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
indicator-sound (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

If not then this bug can be closed
Otherwise in /src/service.vala

   var env = Environment.get_variable ("DESKTOP_SESSION");
   string cmd;
  if (env == "unity")
   cmd = "gnome-control-center sound-nua";

should be "ubuntu"

ProblemType: Bug
DistroRelease: Ubuntu 13.10
Package: indicator-sound 12.10.2+13.10.20131011-0ubuntu1
ProcVersionSignature: Ubuntu 3.11.0-11.17-generic 3.11.3
Uname: Linux 3.11.0-11-generic x86_64
ApportVersion: 2.12.5-0ubuntu2
Architecture: amd64
Date: Mon Oct 14 02:33:01 2013
InstallationDate: Installed on 2013-08-07 (67 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130803)
MarkForUpload: True
SourcePackage: indicator-sound
UpgradeStatus: No upgrade log present (probably fresh install)

See original description

Related branches

lp:~seb128/indicator-sound/dont-special-case-unity
Charles Kerr (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 14 lines (+1/-3)
1 file modified
src/service.vala (+1/-3)
lp:ubuntu/trusty-proposed/indicator-sound
Revision history for this message
Doug McMahon (mc3man) wrote :
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report, I'm changing that code to not special case unity sessions anymore, we do redirect from the gnome-control-center side anyway, that makes more sense than patching all the clients

Changed in indicator-sound (Ubuntu):
status: New → In Progress
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-sound - 12.10.2+14.04.20131029.1-0ubuntu1

---------------
indicator-sound (12.10.2+14.04.20131029.1-0ubuntu1) trusty; urgency=low

  [ Dmitrijs Ledkovs ]
  * Define "ubiquity" indicator profile, reusing the greeter object. (LP:
    #1241539)

  [ Charles Kerr ]
  * When we can't connect to pulse, wait a moment before retrying. (LP:
    #1244010)
  * In Service's volume_changed() function, explicitly instantiate the
    GVariant to avoid leaking it. See the description in bug #1244468
    for before & after C code and more information. (LP: #1244468)
  * Test that MediaPlayer's icon property isn't NULL before we serialize
    it. (LP: #1229612)

  [ Sebastien Bacher ]
  * Don't special case Unity sessions, that's not needed since gnome-
    control-center is doing the right thing, the session name used was
    also wrong and couldn't work (lp: #1239545). (LP: #1239545)

  [ Lars Uebernickel ]
  * Only display running players in the phone's sound menu The design
    says to only display the _one_ running player. This will have that
    effect, as there's only one player allowed to run at a time on the
    phone.
  * VolumeControl: don't pass vala closures into libpulse Libpulse's
    vala bindings don't specify that callbacks passed into some of its
    functions (e.g., get_server_info) can be called after the function
    returns. Vala thus frees closure data after these functions return.
    This can't easily be fixed in the bindings, because libpulse doesn't
    provide variants of these functions with destroy_notifies. This
    patch works around this problem by only passing non-closure
    functions into libpulse. (LP: #1244386)
  * Depend on vala 0.20 and use its GIcon.serialize().

  [ Ted Gould ]
  * Adding a phone_greeter profile.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 399
 -- Ubuntu daily release <email address hidden> Tue, 29 Oct 2013 10:32:48 +0000

Changed in indicator-sound (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.