Code review comment for lp:~larsu/indicator-messages/lp956147

Revision history for this message
Charles Kerr (charlesk) wrote :

Looks good!

I noticed that dbusmenu-glib's menuitem.h has this:

> #define DBUSMENU_MENUITEM_ICON_NAME_BLANK "blank-icon"

so I tweaked the patch to use the symbolic name rather than the string literal.

review: Approve

« Back to merge proposal