Merge lp:~larsu/indicator-messages/lp1386584 into lp:indicator-messages/15.04
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Ted Gould on 2015-01-12 | ||||
Approved revision: | 429 | ||||
Merged at revision: | 433 | ||||
Proposed branch: | lp:~larsu/indicator-messages/lp1386584 | ||||
Merge into: | lp:indicator-messages/15.04 | ||||
Diff against target: |
315 lines (+113/-23) 1 file modified
src/im-application-list.c (+113/-23) |
||||
To merge this branch: | bzr merge lp:~larsu/indicator-messages/lp1386584 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve on 2015-01-12 | ||
Sebastien Bacher | 2014-11-05 | Approve on 2014-12-04 | |
PS Jenkins bot (community) | continuous-integration | Approve on 2014-11-07 | |
Review via email:
|
Commit message
Escape message and source ids when using them as action names
Description of the change
Escape message and source ids when using them as action names
Sebastien Bacher (seb128) wrote : | # |
I didn't review the code but just gave it a round of testing and I can confirm indicator-messages is still working and it's not segfaulting anymore, good job ;-)
Sebastien Bacher (seb128) wrote : | # |
There is no segfault but the notifications fail to clear when you view the messages (it's doing it at least for xchat-gnome and tb, if you get some ping/emails, and go read them, the counter in the launcher is cleared but the envelop stay on blue and the corresponding line is not cleared)
- 429. By Lars Karlitski on 2014-11-07
-
Also escape message and source ids when removing them from the app
The last commit missed these two places.
Lars Karlitski (larsu) wrote : | # |
You're right. I missed two instances of escaping. Thanks for testing!
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:429
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
Sebastien Bacher (seb128) wrote : | # |
The new version works fine, it resolve the segfault issue as well.
Ted/Charles, could you do a code review for it?
PASSED: Continuous integration, rev:428 jenkins. qa.ubuntu. com/job/ indicator- messages- ci/138/ jenkins. qa.ubuntu. com/job/ indicator- messages- utopic- amd64-ci/ 18 jenkins. qa.ubuntu. com/job/ indicator- messages- utopic- armhf-ci/ 18 jenkins. qa.ubuntu. com/job/ indicator- messages- utopic- armhf-ci/ 18/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/indicator- messages- ci/138/ rebuild
http://