Code review comment for lp:~larsu/indicator-messages/fix-leak

This is a nice find, but the fix is slightly wrong:

if g_menu_model_get_item_attribute() returns true, we need to call "g_free (item_sort);" no matter what g_utf8_collate() returns.

Maybe something like

  if (g_menu_model_get_item_attribute (...)
    {
      gint collated = g_utf8_collate (sort_string, item_sort);
      g_free (item_sort);
      if (collated < 0)
        break;
    }