Code review comment for lp:~larsu/ido/lp1080076

Revision history for this message
Charles Kerr (charlesk) wrote :

A good improvement.

One thing I'd like to see is for the new numbers 41, 2, and 76 introduced
in ido_playback_menu_item_draw() to be #defined instead of being raw magic
numbers.

I realize idomediaplayermenuitem.c is already a mess and don't have
any illusions about this making the code right. Still, the signposting will
be useful to anyone who has to work this code in the future.

review: Needs Fixing

« Back to merge proposal