Code review comment for lp:~larsu/gsettings-qt/lp1349787

Revision history for this message
Iain Lane (laney) wrote :

Code looks fine, but a test would be nice please.

I'd have preferred the removals in another branch, but it's okay since they're here already. These weren't in a header file so I think it's fine to remove them despite being public. A symbols map would let you control the exported symbols.

review: Needs Fixing

« Back to merge proposal