Code review comment for lp:~larstiq/bzr-svn/filter_stacks_registry
Revision history for this message
| Wouter van Heyst (larstiq) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Wed, Apr 04, 2012 at 14:42:31 -0000, Jelmer Vernooij wrote:
> Review: Approve code
>
> Thanks, seems good to land. You should be able to do that yourself.
>
> It might be nice to move the register call into an else: clause, though I guess it's not likely that will raise an ImportError anyway.
Yeah, given the remote possibility of raising an ImportError there I
prefer the clarity of keeping the two lines together. Merging and
landing.
Wouter