Merge lp:~larryprice/libertine/lxd-run-user into lp:libertine

Proposed by Larry Price
Status: Merged
Approved by: Christopher Townsend
Approved revision: 329
Merged at revision: 363
Proposed branch: lp:~larryprice/libertine/lxd-run-user
Merge into: lp:libertine
Diff against target: 53 lines (+5/-17)
1 file modified
python/libertine/LxdContainer.py (+5/-17)
To merge this branch: bzr merge lp:~larryprice/libertine/lxd-run-user
Reviewer Review Type Date Requested Status
Christopher Townsend (community) Approve
Libertine CI Bot continuous-integration Approve
Review via email: mp+314257@code.launchpad.net

Commit message

Manually execute lxd bind mount script to fix /run/user and remove service

Description of the change

Manually execute lxd bind mount script to fix /run/user and remove service

To post a comment you must log in.
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

PASSED: Continuous integration, rev:327
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/301/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/build/611
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=default/497
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=zesty,testname=default/497
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=xenial+overlay,testname=default/497
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=zesty,testname=default/497
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/621
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/603
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/603/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/603
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/603/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/603
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/603/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/603
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/603/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/301/rebuild

review: Approve (continuous-integration)
328. By Larry Price

only run the bin on application start

329. By Larry Price

oops self

Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

PASSED: Continuous integration, rev:329
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/303/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/libertine/job/build/613
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=default/498
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=amd64,release=zesty,testname=default/498
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=xenial+overlay,testname=default/498
    SUCCESS: https://jenkins.canonical.com/libertine/job/test-0-autopkgtest/label=i386,release=zesty,testname=default/498
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/623
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/605
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/605/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/605
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/605/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/605
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/605/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/605
        deb: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/605/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/303/rebuild

review: Approve (continuous-integration)
Revision history for this message
Christopher Townsend (townsend) wrote :

Ok, works for me. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'python/libertine/LxdContainer.py'
--- python/libertine/LxdContainer.py 2017-01-05 20:16:25 +0000
+++ python/libertine/LxdContainer.py 2017-01-06 21:59:14 +0000
@@ -98,20 +98,6 @@
9898
9999
100def _setup_bind_mount_service(container, uid, username):100def _setup_bind_mount_service(container, uid, username):
101 utils.get_logger().info("Creating systemd mount override service")
102 service = '''
103[Unit]
104Description=Fix system mounts for libertine
105
106[Service]
107ExecStart=/usr/bin/libertine-lxd-mount-update
108
109[Install]
110WantedBy=multi-user.target
111'''[1:-1]
112 container.files.put('/etc/systemd/system/libertine-lxd-mount-update.service', service.encode('utf-8'))
113 container.execute(shlex.split('chmod 644 /etc/systemd/system/libertine-lxd-mount-update.service'))
114
115 utils.get_logger().info("Creating mount update shell script")101 utils.get_logger().info("Creating mount update shell script")
116 script = '''102 script = '''
117#!/bin/sh103#!/bin/sh
@@ -128,9 +114,6 @@
128 container.files.put('/usr/bin/libertine-lxd-mount-update', script.format(uid=uid, username=username).encode('utf-8'))114 container.files.put('/usr/bin/libertine-lxd-mount-update', script.format(uid=uid, username=username).encode('utf-8'))
129 container.execute(shlex.split('chmod 755 /usr/bin/libertine-lxd-mount-update'))115 container.execute(shlex.split('chmod 755 /usr/bin/libertine-lxd-mount-update'))
130116
131 utils.get_logger().info("Enabling systemd mount update service")
132 container.execute(shlex.split('systemctl enable libertine-lxd-mount-update.service'))
133
134117
135def lxd_container(client, container_id):118def lxd_container(client, container_id):
136 try:119 try:
@@ -404,6 +387,8 @@
404 utils.get_logger().error("Could not get container '{}'".format(self._id))387 utils.get_logger().error("Could not get container '{}'".format(self._id))
405 return None388 return None
406389
390 requires_remount = self._container.status != 'Running'
391
407 if self._manager:392 if self._manager:
408 result = LifecycleResult.from_dict(self._manager.app_start(self._id))393 result = LifecycleResult.from_dict(self._manager.app_start(self._id))
409 else:394 else:
@@ -415,6 +400,9 @@
415 utils.get_logger().error(result.error)400 utils.get_logger().error(result.error)
416 return False401 return False
417402
403 if requires_remount:
404 self._container.execute(shlex.split('/usr/bin/libertine-lxd-mount-update'))
405
418 args = self._lxc_args("sudo -E -u {} env PATH={}".format(os.environ['USER'], environ['PATH']), environ)406 args = self._lxc_args("sudo -E -u {} env PATH={}".format(os.environ['USER'], environ['PATH']), environ)
419407
420 self._start_window_manager(args.copy())408 self._start_window_manager(args.copy())

Subscribers

People subscribed via source and target branches