Merge lp:~larryprice/libertine-scope/full-scope-name into lp:libertine-scope

Proposed by Larry Price
Status: Merged
Approved by: Christopher Townsend
Approved revision: 55
Merged at revision: 59
Proposed branch: lp:~larryprice/libertine-scope/full-scope-name
Merge into: lp:libertine-scope
Diff against target: 36 lines (+3/-5)
2 files modified
scope/apps/action.cpp (+2/-2)
scope/apps/config.h.in (+1/-3)
To merge this branch: bzr merge lp:~larryprice/libertine-scope/full-scope-name
Reviewer Review Type Date Requested Status
Libertine CI Bot continuous-integration Approve
Christopher Townsend Approve
Review via email: mp+301390@code.launchpad.net

Commit message

Use full scope name in canned queries to properly return from Show/Hide actions.

Description of the change

Use full scope name in canned queries to properly return from Show/Hide actions.

To post a comment you must log in.
Revision history for this message
Christopher Townsend (townsend) wrote :

Quick inline comment.

55. By Larry Price

remove SCOPE_PKG

Revision history for this message
Christopher Townsend (townsend) wrote :

Ok, thanks

review: Approve
Revision history for this message
Libertine CI Bot (libertine-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'scope/apps/action.cpp'
--- scope/apps/action.cpp 2016-07-19 20:20:12 +0000
+++ scope/apps/action.cpp 2016-07-28 16:07:51 +0000
@@ -53,14 +53,14 @@
53 {53 {
54 hidden_->add(QString::fromStdString(result()["app_id"].get_string()));54 hidden_->add(QString::fromStdString(result()["app_id"].get_string()));
5555
56 usc::CannedQuery cq(SCOPE_PKG);56 usc::CannedQuery cq(FULLY_QUALIFIED_APPS_SCOPE);
57 return usc::ActivationResponse(cq);57 return usc::ActivationResponse(cq);
58 }58 }
59 else if (action_id_ == "show")59 else if (action_id_ == "show")
60 {60 {
61 hidden_->remove(QString::fromStdString(result()["app_id"].get_string()));61 hidden_->remove(QString::fromStdString(result()["app_id"].get_string()));
6262
63 usc::CannedQuery cq(SCOPE_PKG);63 usc::CannedQuery cq(FULLY_QUALIFIED_APPS_SCOPE);
64 return usc::ActivationResponse(cq);64 return usc::ActivationResponse(cq);
65 }65 }
66 return usc::ActivationResponse(usc::ActivationResponse::Status::NotHandled);66 return usc::ActivationResponse(usc::ActivationResponse::Status::NotHandled);
6767
=== modified file 'scope/apps/config.h.in'
--- scope/apps/config.h.in 2016-07-19 20:20:12 +0000
+++ scope/apps/config.h.in 2016-07-28 16:07:51 +0000
@@ -16,10 +16,8 @@
16#ifndef LIBERTINE_SCOPE_CONFIG_H_16#ifndef LIBERTINE_SCOPE_CONFIG_H_
17#define LIBERTINE_SCOPE_CONFIG_H_17#define LIBERTINE_SCOPE_CONFIG_H_
1818
19const std::string SCOPE_PKG = "@PACKAGE_NAME@";19const std::string FULLY_QUALIFIED_APPS_SCOPE = "@FULLY_QUALIFIED_NAME@";
20const std::string ROOT_DEPT_ID = "root_dept";20const std::string ROOT_DEPT_ID = "root_dept";
21const std::string HIDDEN_DEPT_ID = "hidden_dept";21const std::string HIDDEN_DEPT_ID = "hidden_dept";
2222
23#endif // LIBERTINE_SCOPE_CONFIG_H_23#endif // LIBERTINE_SCOPE_CONFIG_H_
24
25

Subscribers

People subscribed via source and target branches