Merge lp:~larryprice/click-reviewers-tools/optional-desktop-field into lp:click-reviewers-tools

[Larry Price]

Add desktop as optional field for apps. (LP: #1658201)

Add desktop as optional field for apps. (LP: #1658201)

The snapcraft docs insist that apps can have an optional 'desktop' field to point to an internal desktop file lieu of using `setup/gui`.

[Larry Price (larryprice)]

Moving to WIP because this is incomplete... needs to also tell check_meta_gui_desktop that it's alright

[Larry Price (larryprice)]

Upon further inspection, snapcraft actually still copies the specified desktop file to prime/meta/gui, so the other checks seem to still pass. :)

[Jamie Strandboge (jdstrand)]

Thank you for the MP but AIUI snapcraft isn't supposed to pass this through to the snap.yaml and snapcraft 2.26 is going to fix this. Please correct me if this is in error.

review: Needs Information

[Larry Price (larryprice)]

Ah, I hadn't realized they were addressing this within snapcraft itself. I filed this bug because I have a snap being held for manual review in the store because it includes the "desktop" property. If snapcraft 2.26 is released soon, this is a non-issue; hopefully not many others will be affected. Feel free to close.

Unmerged revisions

827. By Larry Price on 2017-01-20

Add desktop as optional field for apps

=== modified file 'clickreviews/sr_common.py'
--- clickreviews/sr_common.py	2017-01-10 16:36:40 +0000
+++ clickreviews/sr_common.py	2017-01-20 21:30:34 +0000
@@ -64,6 +64,7 @@
     apps_required = ['command']
     apps_optional = ['aliases',
                      'daemon',
+                     'desktop',
                      'environment',
                      'stop-command',
                      'stop-timeout',