Code review comment for lp:~laney/ubuntu/quantal/emacs23/merge-23.4

Revision history for this message
Bryce Harrington (bryce) wrote :

<slangasek> it sounds like it might be easier to just shuffle the pockets, and keep the packages in sync with Debian
<infinity> Laney: If... Err, what vorlon said. :P
<infinity> If emacs23-non-dfsg really is just the same stuff that we're adding back in our diff, that seems like a silly amount of effort for us.
<slangasek> the only binary package it builds is emacs23-common-non-dfsg... should that be a dependency of emacs?
<slangasek> honestly, either way, I think that may be the simpler route
<slangasek> i.e. I don't see any barrier to having it in main if that's where it belongs
<slangasek> in fact since it's just a binary package split, it shouldn't need a MIR
<Laney> if we're OK having it in main as a Depends, that should get us to ~ where we are now
<Laney> and let us drop a bunch of delta
<infinity> Sounds reasonable to me.
<bryceh> dropping delta sounds nice
<slangasek> it's just the docs, after all
<slangasek> Laney: I'm in favor of just making it a binary dep from emacs23 and avoiding the horror deltas :)
<slangasek> rather, from emacs23-common
<Laney> rock
<Laney> deleted debian/patches/ubuntu-restore-nondfsg-files.diff

review: Needs Fixing

« Back to merge proposal