Merge lp:~laney/ubuntu-test-cases/touch-boottest-no-download-orig into lp:ubuntu-test-cases/touch
Status: | Superseded |
---|---|
Proposed branch: | lp:~laney/ubuntu-test-cases/touch-boottest-no-download-orig |
Merge into: | lp:ubuntu-test-cases/touch |
Diff against target: |
110 lines (+30/-17) 5 files modified
scripts/boottest.sh (+24/-8) tests/getinstalledpkgs/debian/changelog (+1/-1) tests/getinstalledpkgs/debian/control (+2/-2) tests/getinstalledpkgs/debian/tests/control (+2/-2) tests/getinstalledpkgs/debian/tests/getinstalledpkgs.template (+1/-4) |
To merge this branch: | bzr merge lp:~laney/ubuntu-test-cases/touch-boottest-no-download-orig |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Evan (community) | Needs Information | ||
Review via email: mp+260584@code.launchpad.net |
This proposal has been superseded by a proposal from 2015-06-02.
Description of the change
oxide-qt's boottest fails. psivaa says this is because getpkgsrc can't download the source package due to the device not having enough space.
Looking at the test script it seems as if the whole orig isn't needed - you only want the debian/ part to run the tests, and in "getpkgsrc" itself (outputs the binary packages from a source that are already installed) you can get the necessary information from apt's database directly without needing any part of the source.
We can refactor both parts
- Make getpkgsrc use grep-aptavail from dctrl-tools to do the source to binary mapping. Then it isn't getting the source any more, so I rename it to getinstalledpkgs.
- Use apt-get source --diff-only in the test runner to download the debian directory.
I can't test this, but if someone can and it works then it should be good to land in this state as a drop in replacement.
(I previously said something about getpkgsrc being unnecessary but now I see that it is used later on, so disregard that)
I'm not convinced --diff-only will work here.