Code review comment for lp:~laney/ubuntu-system-settings/show-more-icons

On Fri, Jun 27, 2014 at 05:22:20PM -0000, Sebastien Bacher wrote:
> Looks fine but I didn't review in details, one review comment though
>
> Diff comments:
> […]
> > + if (!appinfo) {
> > + g_warning ("Couldn't parse desktop file %s",
> > + desktopFileName);
> > + return;
>
> "desktopFileName" is leaked in that case

Oh yes, well done. I fixed that now.

Note that the code is mostly moved from one giant function which we had
before to slightly smaller ones. Not the easiest diff to review,
granted.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]