Code review comment for lp:~laney/ubuntu-system-settings/background-gsettings

Revision history for this message
Iain Lane (laney) wrote :

On Fri, Jun 28, 2013 at 10:46:48AM -0000, Sebastien Bacher wrote:
> > Should I depend on gsettings-desktop-schemas too for org.gnome.desktop.background?
>
> yes please

Done.

>
> (not commenting on the other parts yet because I'm trying to wrap my head about the connections/signal stuff used there, would be good if Alberto or Ken could comment on that)

I just got rid of the Connections thing as it was unnecessary - should
be simpler now.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

« Back to merge proposal