Code review comment for lp:~laney/ubuntu-system-settings/as-background-fixes

On Thu, Oct 17, 2013 at 11:49:17AM -0000, Łukasz Zemczak wrote:
> […]
> 1) In the welcomeImage, you need:
>
> + source: backgroundPanel.backgroundFile

No. This goes through the test image. Did you see something break?

> 2) The Change... button needs to have the callback as well, otherwise it doesn't change anything (and breaking v1), so:
>
> - onClicked: startContentTransfer()
> + onClicked: startContentTransfer(function(url) {
> + if (systemSettingsSettings.backgroundDuplicate) {
> + updateBoth(url)
> + } else {
> + updateHome(url)
> + systemSettingsSettings.backgroundSetLast = "home"
> + }
> + })

Okay. It should actually be connected to the click action of the image
instead of duplicating the code.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]