Code review comment for lp:~laney/ubuntu-system-settings/as-background-fixes

I checked if .property() works - and sadly not. It's still returning an empty string for me when doing return userInterface.property("BackgroundFile").toString();, so let's stick with what you have here.

But there are some things that need fixing:

1) In the welcomeImage, you need:

+ source: backgroundPanel.backgroundFile

2) The Change... button needs to have the callback as well, otherwise it doesn't change anything (and breaking v1), so:

- onClicked: startContentTransfer()
+ onClicked: startContentTransfer(function(url) {
+ if (systemSettingsSettings.backgroundDuplicate) {
+ updateBoth(url)
+ } else {
+ updateHome(url)
+ systemSettingsSettings.backgroundSetLast = "home"
+ }
+ })

I guess that's all for now what I saw.