Merge lp:~laney/ubiquity/vte2.91 into lp:ubiquity

Proposed by Iain Lane
Status: Merged
Merged at revision: 6232
Proposed branch: lp:~laney/ubiquity/vte2.91
Merge into: lp:ubiquity
Diff against target: 56 lines (+11/-4)
3 files modified
debian/changelog (+4/-0)
debian/control (+1/-1)
ubiquity/frontend/gtk_ui.py (+6/-3)
To merge this branch: bzr merge lp:~laney/ubiquity/vte2.91
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+241310@code.launchpad.net

Description of the change

Port to the new vte-2.91 API

To post a comment you must log in.
Revision history for this message
Iain Lane (laney) wrote :

In the absence of this being merged + uploaded, the install will probably error out. gi is going to try and use 2.91 if gir1.2-vte-2.91 is installed, and the old code is not compatible.

If you don't have time to review, you could upload with this change to force 2.90 in the meantime.

"import gi
gi.require_version ("Vte", "2.90")"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-10-29 12:33:49 +0000
3+++ debian/changelog 2014-11-10 17:54:21 +0000
4@@ -1,9 +1,13 @@
5 ubiquity (2.21.0) UNRELEASED; urgency=medium
6
7+ [ Colin Watson ]
8 * Go forward rather than back in response to partman-crypto/passphrase and
9 partman-crypto/passphrase-again questions if the UI is not available but
10 they have been preseeded (LP: #1386113).
11
12+ [ Iain Lane ]
13+ * Port the Vte widget to use the 2.91 API.
14+
15 -- Colin Watson <cjwatson@ubuntu.com> Wed, 29 Oct 2014 12:32:44 +0000
16
17 ubiquity (2.20.0) utopic; urgency=medium
18
19=== modified file 'debian/control'
20--- debian/control 2014-07-22 13:54:51 +0000
21+++ debian/control 2014-11-10 17:54:21 +0000
22@@ -45,7 +45,7 @@
23 Package: ubiquity-frontend-gtk
24 Architecture: any
25 Pre-Depends: ${misc:Pre-Depends}
26-Depends: ${shlibs:Depends}, ${misc:Depends}, ${python3:Depends}, ubiquity (= ${binary:Version}), python3-dbus, gir1.2-gtk-3.0, gir1.2-soup-2.4, gir1.2-vte-2.90, gir1.2-webkit-3.0, iso-codes, metacity | marco | xfwm4 | matchbox-window-manager | lubuntu-default-settings | openbox | gnome-shell, gir1.2-xkl-1.0, gir1.2-timezonemap-1.0, python3-gi, python3-cairo, python3-gi-cairo, gir1.2-appindicator3-0.1, busybox-static | busybox
27+Depends: ${shlibs:Depends}, ${misc:Depends}, ${python3:Depends}, ubiquity (= ${binary:Version}), python3-dbus, gir1.2-gtk-3.0, gir1.2-pango-1.0, gir1.2-soup-2.4, gir1.2-vte-2.91, gir1.2-webkit-3.0, iso-codes, metacity | marco | xfwm4 | matchbox-window-manager | lubuntu-default-settings | openbox | gnome-shell, gir1.2-xkl-1.0, gir1.2-timezonemap-1.0, python3-gi, python3-cairo, python3-gi-cairo, gir1.2-appindicator3-0.1, busybox-static | busybox
28 Suggests: gnome-control-center | feh
29 Conflicts: ubuntu-express-frontend-gtk, espresso-frontend-gtk, ubiquity (<< 2.4.3)
30 Replaces: ubuntu-express-frontend-gtk, espresso-frontend-gtk, ubiquity (<< 2.4.3)
31
32=== modified file 'ubiquity/frontend/gtk_ui.py'
33--- ubiquity/frontend/gtk_ui.py 2014-06-30 13:09:16 +0000
34+++ ubiquity/frontend/gtk_ui.py 2014-11-10 17:54:21 +0000
35@@ -901,15 +901,18 @@
36 style.add_class('menubar')
37
38 # TODO lazy load
39- from gi.repository import Vte
40+ import gi
41+ gi.require_version("Vte", "2.91")
42+ from gi.repository import Vte, Pango
43 self.vte = Vte.Terminal()
44 self.install_details_sw.add(self.vte)
45 tail_cmd = [
46 '/bin/busybox', 'tail', '-f', '/var/log/installer/debug',
47 '-f', '/var/log/syslog', '-q',
48 ]
49- self.vte.fork_command_full(0, None, tail_cmd, None, 0, None, None)
50- self.vte.set_font_from_string("Ubuntu Mono 8")
51+ self.vte.spawn_sync(0, None, tail_cmd, None, 0, None, None, None)
52+ fontdesc = Pango.font_description_from_string("Ubuntu Mono 8")
53+ self.vte.set_font(fontdesc)
54 self.vte.show()
55 # FIXME shrink the window horizontally instead of locking the window
56 # size.

Subscribers

People subscribed via source and target branches

to status/vote changes: