Indicator Date and Time

Code review comment for lp:~laney/indicator-datetime/timedated-timezone-property

  1. timedated-timezone-property
  2. Merge into trunk.15.10
Revision history for this message
Iain Lane (laney) wrote :

Updated - please re-review.

Is taking a reference to the GDBusConnection sane? Without it the testsuite kills the connection and the AddMatch fails, which causes some criticals.

(process:12769): GLib-GIO-CRITICAL **: Error while sending AddMatch() message: The connection is closed

(process:12769): GLib-GIO-CRITICAL **: g_dbus_connection_call_finish_internal: assertion 'G_IS_DBUS_CONNECTION (connection)' failed

Maybe we don't care or there's a better way to ensure this can't fail?

« Back to merge proposal