Code review comment for ~laney/germinate:master
Revision history for this message
| Iain Lane (laney) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Um, no, good point. Do those have to have their classicness specified in
> seed.yaml somehow? (I've asked #snappy for clarification as there's no
> documentation I can find. Currently waiting for an answer.)
>
> Do you have a preference on syntax? Maybe "snap:foo/classic"? AFAICS "/" isn't
> used apart from in _filter_packages to specify a regex & that wouldn't apply
> here. For outputting I can imagine either passing that straight through,
> transforming it to "foo (classic)", or adding a new column in increasing order
> of difficulty on the livecd-rootfs side. Not that difficulty there matters too
> much.
OK, I did this. I went for the second option. Classic snaps should be annotated with "/classic", and that is transformed to "(classic)" in the first column of the output.
(In livecd-rootfs I translate that back to "/classic" to make it easier to pass to the function which installs snaps, which is slightly ugly but it seems worth it to me to have a more human-readable output from germinate.)