Code review comment for ~laney/germinate:master
Revision history for this message
| Iain Lane (laney) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Re-pushed, thanks for the review. This time I have added a section to the manpage - please review that.
> Also, have you thought about how we're going to annotate classic snaps? I
> gather that we may want to install both classic and non-classic snaps on
> images ...
Um, no, good point. Do those have to have their classicness specified in seed.yaml somehow? (I've asked #snappy for clarification as there's no documentation I can find. Currently waiting for an answer.)
Do you have a preference on syntax? Maybe "snap:foo/classic"? AFAICS "/" isn't used apart from in _filter_packages to specify a regex & that wouldn't apply here. For outputting I can imagine either passing that straight through, transforming it to "foo (classic)", or adding a new column in increasing order of difficulty on the livecd-rootfs side. Not that difficulty there matters too much.