Ubuntu
ubuntu-advantage-tools package

Code review comment for ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-29.2-mantic

  1. Git
  2. lp:~lamoura/ubuntu/+source/ubuntu-advantage-tools
  3. upload-29.2-mantic
  4. Merge into ubuntu/devel
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

So I talked to Lucas in private, and while pedantically speaking the comparison operator '==' shouldn't be used when comparing strings with '[', bash still supports it (although it is not the standard) and this won't affect the release per se.

Therefore, in order to avoid spending even more time changing the code, I will go ahead and upload the package as is. Lucas also told me that they plan to tackle this specific issue in the next releases.

Uploaded:

$ dput ubuntu-advantage-tools_29.2_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_29.2_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_29.2.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_29.2.dsc: done.
  Uploading ubuntu-advantage-tools_29.2.tar.xz: done.
  Uploading ubuntu-advantage-tools_29.2_source.buildinfo: done.
  Uploading ubuntu-advantage-tools_29.2_source.changes: done.
Successfully uploaded packages.

review: Approve

« Back to merge proposal