Ubuntu
ubuntu-advantage-tools package

Code review comment for ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-29-mantic

  1. Git
  2. lp:~lamoura/ubuntu/+source/ubuntu-advantage-tools
  3. upload-29-mantic
  4. Merge into ubuntu/devel
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thank you, Lucas et al.

I did a second pass to verify the points that I raised, and confirmed that they've been properly addressed.

Everything else LGTM, so I'm approving this MP and uploading the package. Thank you again!

$ dput ubuntu-advantage-tools_29_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_29_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/ubuntu-advantage-tools/ubuntu-advantage-tools_29.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-advantage-tools_29.dsc: done.
  Uploading ubuntu-advantage-tools_29.tar.xz: done.
  Uploading ubuntu-advantage-tools_29_source.buildinfo: done.
  Uploading ubuntu-advantage-tools_29_source.changes: done.
Successfully uploaded packages.

review: Approve

« Back to merge proposal