Code review comment for ~lamoura/ubuntu/+source/ubuntu-advantage-tools:upload-29-mantic

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

> Hello, sergiodj, thanks much for this first round of feedback - appreciated.
>
> So,
>
> > - According to the discussion on https://github.com/canonical/ubuntu-pro-
> client/issues/2463, you had decided to keep the documentation bits as part of
> the tarball but mention that they're not actually used to generate the binary
> package. However, df505d4643a20a7210a9c9ae972678549adc0801 seems to indicate
> that you decided to move the documentation out of the tarball. Is that
> correct? Is this why I don't see a mention to the documentation part in the
> "Particularities" section here?
>
> Sorry, this is on me - I updated the Jira ticket, but not the (public and
> available) GH issue :/
> We have decided to completely remove the documentation bits from the tarball,
> so anyone packaging/sponsoring u-a-t would not need to care about docs in the
> process. We would include it in the readme if we had decided to keep those
> around, but given we removed it, we also don't mention it in the readme.

Thanks for the reply and for clarifying this part, Renan.

« Back to merge proposal