Code review comment for lp:~lamont/maas/domain-detail

Revision history for this message
Mike Pontillo (mpontillo) wrote :

I basically approve, but please check my comments below regarding some mostly-minor nits.

Also, after staring at your HTML and JavaScript long enough, I convinced myself that it was good, but that was after the text morphed into a minotaur and said "ENOUGH! SHIP IT!". And I said "BACK, VILE BEAST! SHOW ME YOUR UNIT TESTS!" ... and it screamed a horrible scream and turned into a pile of dust.

So yeah. Please add a unit test for the new controller. =)

Also, what I think I'm trying to say is, I'd feel more comfortable Blake reviews lines 874 through 1093. ;-)

review: Needs Fixing

« Back to merge proposal