Code review comment for lp:~lamont/maas/dns-testfailures-check-soa

Revision history for this message
Gavin Panella (allenap) wrote :

This is awesome; thank you for fixing those tests, and for the BIND work.

I do have some serious concerns about the code in here, particularly around the changes to Sequence. However, I don't think anything invalidates your approach, it just needs fixing.

I wrote some code as I reviewed this. Where I've proposed new or altered code, you can get it by merging lp:~allenap/maas/dns-testfailures-check-soa if you want.

review: Needs Fixing

« Back to merge proposal