Code review comment for lp:~lamont/maas/dns-2.0

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Nice work, LaMont.

I commented on a few minor issues below; in my mind, the only thing keeping this branch from landing is the 'assert', which we should gracefully log and skip instead, rather than crashing regiond.

See comments below.

review: Needs Fixing

« Back to merge proposal