Code review comment for lp:~lamont/maas/dns-1.9

Revision history for this message
Andres Rodriguez (andreserl) wrote :

I thought that we agarres that since this was a change of behavior we were
going to defer this?

On Thursday, January 7, 2016, LaMont Jones <email address hidden>
wrote:

> LaMont Jones has proposed merging lp:~lamont/maas/dns-1.9 into lp:maas/1.9.
>
> Commit message:
> Correctly manage reverse DNS: do not manage a /16 because the user added a
> /22 network.
>
> Requested reviews:
> MAAS Committers (maas-committers)
> Related bugs:
> Bug #1356012 in MAAS: "maas incorrectly overmanages DNS reverse zones"
> https://bugs.launchpad.net/maas/+bug/1356012
> Bug #1531868 in MAAS: "Add network fails for multiple bigger-than-/24
> networks in a single /16"
> https://bugs.launchpad.net/maas/+bug/1531868
>
> For more details, see:
> https://code.launchpad.net/~lamont/maas/dns-1.9/+merge/281879
>
> Correctly manage reverse DNS: do not manage a /16 because the user added a
> /22 network.
> --
> Your team MAAS Committers is requested to review the proposed merge of
> lp:~lamont/maas/dns-1.9 into lp:maas/1.9.
>

--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

« Back to merge proposal