Merge lp:~lamont/launchpad-buildd/lp-buildd-97 into lp:launchpad-buildd

Proposed by LaMont Jones
Status: Merged
Approved by: Jelmer Vernooij
Approved revision: 21
Merged at revision: 21
Proposed branch: lp:~lamont/launchpad-buildd/lp-buildd-97
Merge into: lp:launchpad-buildd
Diff against target: 33 lines (+14/-1)
2 files modified
debian/changelog (+13/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~lamont/launchpad-buildd/lp-buildd-97
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) Approve
Review via email: mp+82265@code.launchpad.net

Description of the change

bzr-builder is not compatible with happiness in places where it isn't wanted. We'll handle installing it on the ppa builders as part of the auto install.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Happiness isn't wanted in some places?

Handling bzr-builder in the builders as part of the auto install doesn't seem unreasonable, but I'm curious how bzr-builder is breaking things.

review: Approve
Revision history for this message
LaMont Jones (lamont) wrote :

we lacked bzr-builder for maverick and natty (arm boxes). and likewise, we don't want to be testing bzr-builder on a large number of releases where we won't actually be running it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-11-11 12:19:38 +0000
3+++ debian/changelog 2011-11-15 10:36:26 +0000
4@@ -1,3 +1,16 @@
5+launchpad-buildd (97) hardy-cat; urgency=low
6+
7+ * drop bzr-builder dependency entirely and handle it in the autoinstall
8+ process on x86 virtual builders
9+
10+ -- LaMont Jones <lamont@canonical.com> Tue, 15 Nov 2011 03:15:23 -0700
11+
12+launchpad-buildd (96) hardy-cat; urgency=low
13+
14+ * only depend on bzr-builder on i386.
15+
16+ -- LaMont Jones <lamont@canonical.com> Tue, 15 Nov 2011 02:46:54 -0700
17+
18 launchpad-buildd (95) hardy; urgency=low
19
20 * Add explicit dependency on pristine-tar, recommended by newer
21
22=== modified file 'debian/control'
23--- debian/control 2011-11-11 12:19:38 +0000
24+++ debian/control 2011-11-15 10:36:26 +0000
25@@ -8,7 +8,7 @@
26 Package: launchpad-buildd
27 Section: misc
28 Architecture: all
29-Depends: python-lpbuildd, debootstrap, dpkg-dev, linux32, file, bzip2, sudo, ntpdate, adduser, apt-transport-https, lsb-release, apache2, bzr-builder (>= 0.7.1), pristine-tar, ${misc:Depends}
30+Depends: python-lpbuildd, debootstrap, dpkg-dev, linux32, file, bzip2, sudo, ntpdate, adduser, apt-transport-https, lsb-release, apache2, pristine-tar, ${misc:Depends}
31 Description: Launchpad buildd slave
32 This is the launchpad buildd slave package. It contains everything needed to
33 get a launchpad buildd going apart from the database manipulation required to

Subscribers

People subscribed via source and target branches