Code review comment for lp:~laetitia-gangloff/hr-timesheet/migrationV7

Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Hello,

Thanks for the merge proposal.

Please do not rename work_ids to aa_ids we keep the name for compatibility reason and to avoid to redefine some view. It will also be harder to migrate the module.

I think we have also done some work internally to migrate this add-on. If it is the case I will ask my colleague join his work with yours if you do not mind.

Regards

review: Needs Fixing

« Back to merge proposal