Code review comment for lp:~laetitia-gangloff/account-invoicing/account_invoice_merge

Revision history for this message
Laetitia Gangloff (Acsone) (laetitia-gangloff) wrote :

Hello,

I refactor do_merge method using Romain's changes.
I remove unused import and correct the comment indentation.

doesn't po and so need to be rewritten with invoice ids ?
As suggested by Stéphane, the part which reconnects the so/po to the invoice move from wizard/invoice_merge.py to invoice.py/do_merge() so do_merge implements the whole algorithm and can be called from elsewhere without surprise.

Thank you

« Back to merge proposal