Code review comment for lp:~laetitia-gangloff/account-invoicing/account_invoice_merge

Revision history for this message
Stéphane Bidoul (Acsone) (sbi) wrote :

Hello Guewen and community,

Y <email address hidden>es they the MP have the same goal and stem
from the same Elico module. Apparently both teams did the same work in the
exact same timeframe. Romain's branch came one day before Laetitia's.

There is a process question here: how can we (not being part of the
Community Reviewers group - yet :) receive notifications of changes and MP
to community branches? The question is even broader: how can someone
interested in doing some code review receive notifications of community
activities. Thanks in advance for hints in this area.

Now these two MP need to be merged. At first glance there is good
improvements in both. It seems Laetitia's branch got a bit more scrutiny so
far? Another way to decide which of the two goes forward could be to decide
the best project to receive it. Is it account-invoicing, or
account-financial-tools. My intuition would go to account-invoicing as this
module is exclusively about invoices.

-sbi

On Mon, Jul 22, 2013 at 10:20 AM, Guewen Baconnier @ Camptocamp <
<email address hidden>> wrote:

> Review: Needs Information
>
> Is it the same module than?
>
> https://code.launchpad.net/~camptocamp/account-financial-tools/7.0-add-account_invoice_merge/+merge/171119
>
> Can both MPs converge in an unique MP?
> --
>
> https://code.launchpad.net/~laetitia-gangloff/account-invoicing/account_invoice_merge/+merge/171247
> You are reviewing the proposed merge of
> lp:~laetitia-gangloff/account-invoicing/account_invoice_merge into
> lp:account-invoicing.
>

« Back to merge proposal