Merge lp:~l3on/ubuntu/precise/flowscan/fix-ftbfs into lp:ubuntu/precise/flowscan

Proposed by Leo Iannacone
Status: Merged
Merge reported by: Adam Conrad
Merged at revision: not available
Proposed branch: lp:~l3on/ubuntu/precise/flowscan/fix-ftbfs
Merge into: lp:ubuntu/precise/flowscan
Diff against target: 136 lines (+69/-8)
6 files modified
configure (+4/-4)
configure.in (+3/-3)
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/fix-ftbfs-with-netbase-4.47.patch (+53/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~l3on/ubuntu/precise/flowscan/fix-ftbfs
Reviewer Review Type Date Requested Status
Andreas Moog (community) Needs Information
Ubuntu branches Pending
Review via email: mp+94884@code.launchpad.net

Description of the change

In netbase port 80/tcp is marked as 'http', no longer as 'www'.
This causes flowscan to fail during build while configure search for port
80/tcp masked as 'www'.
This patch update configure and configure.in to look for service 'http' instead
of 'www'.

To post a comment you must log in.
Revision history for this message
Andreas Moog (ampelbein) wrote :

You said on the debian report that you uploaded a NMU for this. I guess in that case we can wait the 3 days and sync from debian. What do you think?

review: Needs Information
Revision history for this message
Daniel Holbach (dholbach) wrote :

This doesn't seem to have landed in Debian yet. Shall we get it in and sync once it lands there?

Revision history for this message
Adam Conrad (adconrad) wrote :

I'm marking this as merged because I intend to just sync the NMU from unstable as soon as it gets out of incoming.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure'
--- configure 2004-03-09 18:34:21 +0000
+++ configure 2012-02-27 23:52:19 +0000
@@ -1296,14 +1296,14 @@
12961296
12971297
12981298
1299echo $ac_n "checking that service name for 80/tcp is www""... $ac_c" 1>&61299echo $ac_n "checking that service name for 80/tcp is http""... $ac_c" 1>&6
1300echo "configure:1301: checking that service name for 80/tcp is www" >&51300echo "configure:1301: checking that service name for 80/tcp is http" >&5
1301if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'1301if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
1302then1302then
1303 echo "$ac_t""yes" 1>&61303 echo "$ac_t""yes" 1>&6
1304else1304else
1305 echo "$ac_t""no" 1>&61305 echo "$ac_t""no" 1>&6
1306 { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is www with alias http" 1>&2; exit 1; }1306 { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is http with alias www" 1>&2; exit 1; }
1307fi1307fi
13081308
1309trap '' 1 2 151309trap '' 1 2 15
13101310
=== modified file 'configure.in'
--- configure.in 2004-03-09 18:34:21 +0000
+++ configure.in 2012-02-27 23:52:19 +0000
@@ -135,13 +135,13 @@
135135
136dnl Checks for misc.136dnl Checks for misc.
137137
138AC_MSG_CHECKING(that service name for 80/tcp is www)138AC_MSG_CHECKING(that service name for 80/tcp is http)
139if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'139if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
140then140then
141 AC_MSG_RESULT(yes)141 AC_MSG_RESULT(yes)
142else142else
143 AC_MSG_RESULT(no)143 AC_MSG_RESULT(no)
144 AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is www with alias http, www-http)144 AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is http with alias www, www-http)
145fi145fi
146146
147AC_OUTPUT(Makefile flowscan graphs.mf example/crontab util/locker util/add_ds.pl util/add_txrx util/event2vrule util/ip2hostname)147AC_OUTPUT(Makefile flowscan graphs.mf example/crontab util/locker util/add_ds.pl util/add_txrx util/event2vrule util/ip2hostname)
148148
=== modified file 'debian/changelog'
--- debian/changelog 2009-05-13 18:27:03 +0000
+++ debian/changelog 2012-02-27 23:52:19 +0000
@@ -1,3 +1,9 @@
1flowscan (1.006-13ubuntu1) precise; urgency=low
2
3 * Fix configure looking for http service (LP: #935087).
4
5 -- Leo Iannacone <l3on@ubuntu.com> Sun, 19 Feb 2012 14:08:14 +0100
6
1flowscan (1.006-13) unstable; urgency=low7flowscan (1.006-13) unstable; urgency=low
28
3 * New maintainer (Closes: #402663).9 * New maintainer (Closes: #402663).
410
=== modified file 'debian/control'
--- debian/control 2009-05-13 18:27:03 +0000
+++ debian/control 2012-02-27 23:52:19 +0000
@@ -1,7 +1,8 @@
1Source: flowscan1Source: flowscan
2Section: net2Section: net
3Priority: optional3Priority: optional
4Maintainer: Guillaume Delacour <gui@iroqwa.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Guillaume Delacour <gui@iroqwa.org>
5Build-Depends-Indep: perl (>= 5.6.1), rrdtool, librrds-perl, libboulder-perl, libnet-patricia-perl (>= 1.010), libconfigreader-perl, libcflow-perl (>= 1.024), libhtml-table-perl, netbase, po-debconf, ksh | mksh | pdksh | zsh, autotools-dev6Build-Depends-Indep: perl (>= 5.6.1), rrdtool, librrds-perl, libboulder-perl, libnet-patricia-perl (>= 1.010), libconfigreader-perl, libcflow-perl (>= 1.024), libhtml-table-perl, netbase, po-debconf, ksh | mksh | pdksh | zsh, autotools-dev
6Standards-Version: 3.8.17Standards-Version: 3.8.1
7Homepage: http://net.doit.wisc.edu/~plonka/FlowScan/8Homepage: http://net.doit.wisc.edu/~plonka/FlowScan/
89
=== added directory 'debian/patches'
=== added file 'debian/patches/fix-ftbfs-with-netbase-4.47.patch'
--- debian/patches/fix-ftbfs-with-netbase-4.47.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/fix-ftbfs-with-netbase-4.47.patch 2012-02-27 23:52:19 +0000
@@ -0,0 +1,53 @@
1Description: In netbase port 80/tcp is marked as 'http', no longer as 'www'.
2 This causes flowscan to fail during build while configure search for port
3 80/tcp masked as 'www'.
4 This patch update configure and configure.in to look for service 'http' instead
5 'www'.
6Author: Leo Iannacone <l3on@ubuntu.com>
7Bug-Ubuntu: https://bugs.launchpad.net/bugs/935087
8
9---
10 configure | 8 ++++----
11 configure.in | 6 +++---
12 2 files changed, 7 insertions(+), 7 deletions(-)
13
14--- flowscan.orig/configure
15+++ flowscan/configure
16@@ -1296,14 +1296,14 @@ fi
17
18
19
20-echo $ac_n "checking that service name for 80/tcp is www""... $ac_c" 1>&6
21-echo "configure:1301: checking that service name for 80/tcp is www" >&5
22-if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'
23+echo $ac_n "checking that service name for 80/tcp is http""... $ac_c" 1>&6
24+echo "configure:1301: checking that service name for 80/tcp is http" >&5
25+if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
26 then
27 echo "$ac_t""yes" 1>&6
28 else
29 echo "$ac_t""no" 1>&6
30- { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is www with alias http" 1>&2; exit 1; }
31+ { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is http with alias www" 1>&2; exit 1; }
32 fi
33
34 trap '' 1 2 15
35--- flowscan.orig/configure.in
36+++ flowscan/configure.in
37@@ -135,13 +135,13 @@ dnl Checks for library functions.
38
39 dnl Checks for misc.
40
41-AC_MSG_CHECKING(that service name for 80/tcp is www)
42-if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'
43+AC_MSG_CHECKING(that service name for 80/tcp is http)
44+if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
45 then
46 AC_MSG_RESULT(yes)
47 else
48 AC_MSG_RESULT(no)
49- AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is www with alias http, www-http)
50+ AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is http with alias www, www-http)
51 fi
52
53 AC_OUTPUT(Makefile flowscan graphs.mf example/crontab util/locker util/add_ds.pl util/add_txrx util/event2vrule util/ip2hostname)
054
=== added file 'debian/patches/series'
--- debian/patches/series 1970-01-01 00:00:00 +0000
+++ debian/patches/series 2012-02-27 23:52:19 +0000
@@ -0,0 +1,1 @@
1fix-ftbfs-with-netbase-4.47.patch

Subscribers

People subscribed via source and target branches

to all changes: