Merge lp:~l3on/ubuntu/precise/flowscan/fix-ftbfs into lp:ubuntu/precise/flowscan

Proposed by Leo Iannacone
Status: Merged
Merge reported by: Adam Conrad
Merged at revision: not available
Proposed branch: lp:~l3on/ubuntu/precise/flowscan/fix-ftbfs
Merge into: lp:ubuntu/precise/flowscan
Diff against target: 136 lines (+69/-8)
6 files modified
configure (+4/-4)
configure.in (+3/-3)
debian/changelog (+6/-0)
debian/control (+2/-1)
debian/patches/fix-ftbfs-with-netbase-4.47.patch (+53/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~l3on/ubuntu/precise/flowscan/fix-ftbfs
Reviewer Review Type Date Requested Status
Andreas Moog (community) Needs Information
Ubuntu branches Pending
Review via email: mp+94884@code.launchpad.net

Description of the change

In netbase port 80/tcp is marked as 'http', no longer as 'www'.
This causes flowscan to fail during build while configure search for port
80/tcp masked as 'www'.
This patch update configure and configure.in to look for service 'http' instead
of 'www'.

To post a comment you must log in.
Revision history for this message
Andreas Moog (ampelbein) wrote :

You said on the debian report that you uploaded a NMU for this. I guess in that case we can wait the 3 days and sync from debian. What do you think?

review: Needs Information
Revision history for this message
Daniel Holbach (dholbach) wrote :

This doesn't seem to have landed in Debian yet. Shall we get it in and sync once it lands there?

Revision history for this message
Adam Conrad (adconrad) wrote :

I'm marking this as merged because I intend to just sync the NMU from unstable as soon as it gets out of incoming.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure'
2--- configure 2004-03-09 18:34:21 +0000
3+++ configure 2012-02-27 23:52:19 +0000
4@@ -1296,14 +1296,14 @@
5
6
7
8-echo $ac_n "checking that service name for 80/tcp is www""... $ac_c" 1>&6
9-echo "configure:1301: checking that service name for 80/tcp is www" >&5
10-if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'
11+echo $ac_n "checking that service name for 80/tcp is http""... $ac_c" 1>&6
12+echo "configure:1301: checking that service name for 80/tcp is http" >&5
13+if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
14 then
15 echo "$ac_t""yes" 1>&6
16 else
17 echo "$ac_t""no" 1>&6
18- { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is www with alias http" 1>&2; exit 1; }
19+ { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is http with alias www" 1>&2; exit 1; }
20 fi
21
22 trap '' 1 2 15
23
24=== modified file 'configure.in'
25--- configure.in 2004-03-09 18:34:21 +0000
26+++ configure.in 2012-02-27 23:52:19 +0000
27@@ -135,13 +135,13 @@
28
29 dnl Checks for misc.
30
31-AC_MSG_CHECKING(that service name for 80/tcp is www)
32-if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'
33+AC_MSG_CHECKING(that service name for 80/tcp is http)
34+if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
35 then
36 AC_MSG_RESULT(yes)
37 else
38 AC_MSG_RESULT(no)
39- AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is www with alias http, www-http)
40+ AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is http with alias www, www-http)
41 fi
42
43 AC_OUTPUT(Makefile flowscan graphs.mf example/crontab util/locker util/add_ds.pl util/add_txrx util/event2vrule util/ip2hostname)
44
45=== modified file 'debian/changelog'
46--- debian/changelog 2009-05-13 18:27:03 +0000
47+++ debian/changelog 2012-02-27 23:52:19 +0000
48@@ -1,3 +1,9 @@
49+flowscan (1.006-13ubuntu1) precise; urgency=low
50+
51+ * Fix configure looking for http service (LP: #935087).
52+
53+ -- Leo Iannacone <l3on@ubuntu.com> Sun, 19 Feb 2012 14:08:14 +0100
54+
55 flowscan (1.006-13) unstable; urgency=low
56
57 * New maintainer (Closes: #402663).
58
59=== modified file 'debian/control'
60--- debian/control 2009-05-13 18:27:03 +0000
61+++ debian/control 2012-02-27 23:52:19 +0000
62@@ -1,7 +1,8 @@
63 Source: flowscan
64 Section: net
65 Priority: optional
66-Maintainer: Guillaume Delacour <gui@iroqwa.org>
67+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
68+XSBC-Original-Maintainer: Guillaume Delacour <gui@iroqwa.org>
69 Build-Depends-Indep: perl (>= 5.6.1), rrdtool, librrds-perl, libboulder-perl, libnet-patricia-perl (>= 1.010), libconfigreader-perl, libcflow-perl (>= 1.024), libhtml-table-perl, netbase, po-debconf, ksh | mksh | pdksh | zsh, autotools-dev
70 Standards-Version: 3.8.1
71 Homepage: http://net.doit.wisc.edu/~plonka/FlowScan/
72
73=== added directory 'debian/patches'
74=== added file 'debian/patches/fix-ftbfs-with-netbase-4.47.patch'
75--- debian/patches/fix-ftbfs-with-netbase-4.47.patch 1970-01-01 00:00:00 +0000
76+++ debian/patches/fix-ftbfs-with-netbase-4.47.patch 2012-02-27 23:52:19 +0000
77@@ -0,0 +1,53 @@
78+Description: In netbase port 80/tcp is marked as 'http', no longer as 'www'.
79+ This causes flowscan to fail during build while configure search for port
80+ 80/tcp masked as 'www'.
81+ This patch update configure and configure.in to look for service 'http' instead
82+ 'www'.
83+Author: Leo Iannacone <l3on@ubuntu.com>
84+Bug-Ubuntu: https://bugs.launchpad.net/bugs/935087
85+
86+---
87+ configure | 8 ++++----
88+ configure.in | 6 +++---
89+ 2 files changed, 7 insertions(+), 7 deletions(-)
90+
91+--- flowscan.orig/configure
92++++ flowscan/configure
93+@@ -1296,14 +1296,14 @@ fi
94+
95+
96+
97+-echo $ac_n "checking that service name for 80/tcp is www""... $ac_c" 1>&6
98+-echo "configure:1301: checking that service name for 80/tcp is www" >&5
99+-if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'
100++echo $ac_n "checking that service name for 80/tcp is http""... $ac_c" 1>&6
101++echo "configure:1301: checking that service name for 80/tcp is http" >&5
102++if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
103+ then
104+ echo "$ac_t""yes" 1>&6
105+ else
106+ echo "$ac_t""no" 1>&6
107+- { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is www with alias http" 1>&2; exit 1; }
108++ { echo "configure: error: Please change /etc/services so that the service name for 80/tcp is http with alias www" 1>&2; exit 1; }
109+ fi
110+
111+ trap '' 1 2 15
112+--- flowscan.orig/configure.in
113++++ flowscan/configure.in
114+@@ -135,13 +135,13 @@ dnl Checks for library functions.
115+
116+ dnl Checks for misc.
117+
118+-AC_MSG_CHECKING(that service name for 80/tcp is www)
119+-if $PERL_PATH -I$perllib -MSocket -e 'exit("www" eq getservbyport(80, "tcp")? 0 : 1)'
120++AC_MSG_CHECKING(that service name for 80/tcp is http)
121++if $PERL_PATH -I$perllib -MSocket -e 'exit("http" eq getservbyport(80, "tcp")? 0 : 1)'
122+ then
123+ AC_MSG_RESULT(yes)
124+ else
125+ AC_MSG_RESULT(no)
126+- AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is www with alias http, www-http)
127++ AC_MSG_ERROR(Please change /etc/services so that the service name for 80/tcp is http with alias www, www-http)
128+ fi
129+
130+ AC_OUTPUT(Makefile flowscan graphs.mf example/crontab util/locker util/add_ds.pl util/add_txrx util/event2vrule util/ip2hostname)
131
132=== added file 'debian/patches/series'
133--- debian/patches/series 1970-01-01 00:00:00 +0000
134+++ debian/patches/series 2012-02-27 23:52:19 +0000
135@@ -0,0 +1,1 @@
136+fix-ftbfs-with-netbase-4.47.patch

Subscribers

People subscribed via source and target branches

to all changes: