Code review comment for lp:~l3on/ubuntu-themes/gnome-shell-fixes

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

I've given to this a first look and it seems very good...
However, in order to match the unity defined shadows you should use this:

.window-frame {
    border-radius: 10px 10px 0 0;
    box-shadow: 2px 10px 30px @window_shadow;

    /* this is used for the resize cursor area */
    margin: 10px;
}

.window-frame:backdrop {
    box-shadow: 2px 10px 25px @window_shadow_inactive;
}

Then, we've a problem... At least in unity: what in unity is a toolbar, using this theme becomes an headerbar and thus here it looks like we've two headers, which is something we can't go with.

So, I'm not sure weather it's the case of fixing nautilus or adding some special theming for Nautilus. I've noticed that using the Adwaita theme this problem doesn't happen here.

« Back to merge proposal