Code review comment for lp:~l3on/ubuntu-packaging-guide/new-sidebar

Revision history for this message
Leo Iannacone (l3on) wrote :

Hi Daniel!

How are you? :)

I worked a bit on those issues..

 - BORROWED-CODE should be fixed (I think)

 - I worked a bit on singlehtml, toc now is fixed.
   Anyway I found there a new problem regarding toc and "if the browser window is not enough big", more precisely: if windows.height < toc.height, you'll see only a part of the entire toc.
   I think the best way to fix it is avoid this behaviour if the window is too small (that's what I did).
   Anyway, if we could "split" theme for singlehtml and html version, we would be able to make the JUMP_TO_TOP link smarter for this case...

Best,

Leo.

« Back to merge proposal