Code review comment for lp:~l3on/ubuntu-packaging-guide/new-sidebar

Revision history for this message
Leo Iannacone (l3on) wrote :

> Thanks a lot for your work on this Leon!

You're welcome Daniel!

> I have a few questions:
>
> - Why do you reset LANGS? I'm not sure I understand what's going on. :-)

That was a push mistake, I mean: I reset LANGS for speed up test builds and I forgot to revert before propose the merge. [fixed]

> - Do we specifically need jquery 1.6.1? Or is anything >= 1.6.1 fine? If so,
> we could rely on the system jquery, which has been >= 1.6.1 since oneiric.

I checked if everything works fine also with jquery 1.7.1, and it does... So, no problem with jquery >= 1.6.1

> - Could you document in BORROWED-CODE where you got the icons from?

Yes, of course! [done]

> Thanks again for your great work! This is great!

Thank you! :)

« Back to merge proposal