Ubuntu Packaging Guide

Code review comment for lp:~l3on/ubuntu-packaging-guide/new-sidebar

  1. new-sidebar
  2. Merge into trunk
Revision history for this message
Daniel Holbach (dholbach) wrote :

Thanks a lot for your work on this Leon!

I have a few questions:

 - Why do you reset LANGS? I'm not sure I understand what's going on. :-)
 - Do we specifically need jquery 1.6.1? Or is anything >= 1.6.1 fine? If so,
   we could rely on the system jquery, which has been >= 1.6.1 since oneiric.
 - Could you document in BORROWED-CODE where you got the icons from?

Thanks again for your great work! This is great!

review: Needs Information

« Back to merge proposal