Code review comment for lp:~l0rdt/mixxx/features_replaygain
Revision history for this message
| Sean M. Pappalardo (pegasus-renegadetech) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I just tested this branch and it looks good from a UI perspective. I would suggest adding labels for each tick of the initial boost slider. It would also be nice if you added qDebugs at track load time saying if a track is being analyzed for ReplayGain (if the analyzer is enabled,) and what a track's ReplayGain value is, or not present.
I also noticed that the enabled/disabled setting didn't save every time I restarted Mixxx.
Now, as far as max dynamic range in the deck pre-fader signal path after ReplayGain, is it possible to auto-adjust the gain knob so that the highest peak of the song is just below clipping?