Code review comment for lp:~l-admin-3/gala/workspace-switcher-background-setting

Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

Ok, I think I have understand what you mean, thanks!

I have choosen this fallback-check, because that checks if the file is readable, too. A filename check would only check if the file exists and not if the read permissions are set. Also I have used the same check like that to load the wallpaper, so the code would be more consistent.

What?! An elementary developer says I shouldn't use elementary software? ;) Isn't there any workaround for Scratch?
What is the correct format for the file endings? One empty line after the last braceright?

Do you mean I should merge trunk into my branch?

Sorry, I'm new to elementary-, Vala- and Linux-development...

« Back to merge proposal