Merge ~kzapalowicz/snappy-hwe-snaps/+git/tpm:fix/adopt-new-aliases into ~snappy-hwe-team/snappy-hwe-snaps/+git/tpm:master

Proposed by Konrad Zapałowicz
Status: Merged
Approved by: Simon Fels
Approved revision: 5c673076f851ee21cd960d447a101ec3a681d4ad
Merged at revision: c6b12dbf73b02899d47086875bece39841655442
Proposed branch: ~kzapalowicz/snappy-hwe-snaps/+git/tpm:fix/adopt-new-aliases
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/tpm:master
Diff against target: 33 lines (+9/-1)
2 files modified
snapcraft.yaml (+3/-0)
tests/lib/utilities.sh (+6/-1)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+323974@code.launchpad.net

Description of the change

Adopt for new aliases coming with 2.25

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/snapcraft.yaml b/snapcraft.yaml
index bee4825..60aafae 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -7,6 +7,9 @@ description: |
7 code at: https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/tpm7 code at: https://code.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/tpm
8confinement: strict8confinement: strict
99
10# NOTE: the alias syntax is depreciated with snapd 2.25 however it needs to
11# stay to guarantee that all clients are updated correctly.
12
10apps:13apps:
11 tcsd:14 tcsd:
12 command: sbin/tcsd -f -c $SNAP/etc/tcsd.conf15 command: sbin/tcsd -f -c $SNAP/etc/tcsd.conf
diff --git a/tests/lib/utilities.sh b/tests/lib/utilities.sh
index a9c015a..72da575 100644
--- a/tests/lib/utilities.sh
+++ b/tests/lib/utilities.sh
@@ -32,8 +32,13 @@ install_snap_under_test() {
32 snap connect tpm:$plug core32 snap connect tpm:$plug core
33 done33 done
34 # Setup all necessary aliases34 # Setup all necessary aliases
35 snapd_version=$(snap version | awk '/^snapd / {print $2; exit}')
35 for alias in $SNAP_AUTO_ALIASES ; do36 for alias in $SNAP_AUTO_ALIASES ; do
36 snap alias $SNAP_NAME $alias37 target=$SNAP_NAME.$alias
38 if dpkg --compare-versions $snapd_version lt 2.25 ; then
39 target=$SNAP_NAME
40 fi
41 snap alias $target $alias
37 done42 done
38 fi43 fi
39}44}

Subscribers

People subscribed via source and target branches